SIM/qucs_s
1
0
Fork 0
mirror of https://github.com/ra3xdh/qucs_s synced 2025-03-28 21:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove warnings

Browse Source 
1) The warning is related to a potential performance issue with Qt containers when used in C++11 range-based for loops

"c++11 range-loop might detach Qt container (QList) [clazy-range-loop-detach]"

2) tmp variable unused in exit() function
This commit is contained in:
andresmmera 2024-09-13 15:27:05 +02:00
parent 77b46ef21e
commit 54bd742ffc
1 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
qucs-s-spar-viewer/qucs-s-spar-viewer.cpp
View File

@ -192,8 +192,8 @@ Qucs_S_SPAR_Viewer::Qucs_S_SPAR_Viewer()
available_x_axis_div.clear();
available_x_axis_div << 2000 << 1000 << 500 << 400 << 200 << 100 << 50 << 25 << 20 << 10 << 5 << 1 << 0.5 << 0.2 << 0.1;
for (const double &value : available_x_axis_div) {
QComboBox_x_axis_div->addItem(QString::number(value));
for (const double &value : qAsConst(available_x_axis_div)) {
QComboBox_x_axis_div->addItem(QString::number(value));
}
connect(QComboBox_x_axis_div, SIGNAL(currentIndexChanged(int)), SLOT(updatePlot()));
@ -462,13 +462,6 @@ void Qucs_S_SPAR_Viewer::slotHelpAbout()
void Qucs_S_SPAR_Viewer::slotQuit()
{
int tmp;
tmp = x();
tmp = y();
tmp = width();
tmp = height();
Q_UNUSED(tmp);
qApp->quit();
}
@ -743,7 +736,6 @@ void Qucs_S_SPAR_Viewer::addFiles(QStringList fileNames)
// 4) Add new dataset to the trace selection combobox
QCombobox_datasets->addItem(filename);
QString current_dataset = QCombobox_datasets->currentText();
// Update traces
updateTracesCombo();
}
@ -1415,9 +1407,10 @@ void Qucs_S_SPAR_Viewer::updateTraces()
QList<QAbstractSeries *> seriesList = chart->series();
// Remove series from the chart
for (QAbstractSeries *series : seriesList) {
chart->removeSeries(series);
}
for (QAbstractSeries *series : qAsConst(seriesList)) {
chart->removeSeries(series);
}
double freq_scale = getFreqScale();
@ -1431,7 +1424,7 @@ void Qucs_S_SPAR_Viewer::updateTraces()
// Remove marker traces
// Iterate through the series list
QList<QAbstractSeries *> seriesToRemove;
for (QAbstractSeries *series : seriesList) {
for (QAbstractSeries *series : qAsConst(seriesList)) {
//qDebug() << series->name();
if (series->name().startsWith("Mkr", Qt::CaseInsensitive)) {
seriesToRemove.append(series);
@ -1934,7 +1927,7 @@ QPointF Qucs_S_SPAR_Viewer::findClosestPoint(QAbstractSeries* series, qreal targ
qreal minDistance = qAbs(targetX - closestPoint.x());
// Iterate through all points to find the closest one
for (const QPointF& point : points) {
for (const QPointF& point : qAsConst(points)) {
qreal distance = qAbs(targetX - point.x());
if (distance < minDistance) {
minDistance = distance;
@ -2168,7 +2161,7 @@ void Qucs_S_SPAR_Viewer::dropEvent(QDropEvent *event)
QList<QUrl> urls = event->mimeData()->urls();
QStringList fileList;
for (const QUrl &url : urls) {
for (const QUrl &url : qAsConst(urls)) {
if (url.isLocalFile()) {
fileList << url.toLocalFile();
}