SIM/qucs_s
1
0
Fork 0
mirror of https://github.com/ra3xdh/qucs_s synced 2025-03-28 21:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1278 from wawuwo/fix-1273-crash-in-one-two-wires

Browse Source 
Fix crash when coordinates of wire ends are in wrong order

Fix #1273
This commit is contained in:
wawuwo 2025-03-25 21:07:56 +01:00 committed by GitHub
commit 565efd3b81
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
qucs/schematic_file.cpp
View File

@ -983,7 +983,26 @@ bool Schematic::loadWires(QTextStream *stream, QList<Element*> *List)
List->append(w);
if(w->Label) List->append(w->Label);
}
else simpleInsertWire(w);
else {
// Quick fix for ra3xdh#1273.
//
// A wire whose (x1,y1) coordinates are not less than (x2,y2)
// coordinates somehow deals some damage like crashes or funny behaviour.
//
// I wasn't able to understand how exactly this happens, i.e. why it's
// important to have x1 less than x2 for a wire, so I decided to fix this
// in a most straightforward way by "normalizing" the wire before installing
// it into schematic
if (w->x1 > w->x2) {
std::swap(w->x1, w->x2);
std::swap(w->y1, w->y2);
} else if (w->x1 == w->x2 && w->y1 > w->y2) {
std::swap(w->x1, w->x2);
std::swap(w->y1, w->y2);
}
simpleInsertWire(w);
}
}
QMessageBox::critical(0, QObject::tr("Error"),