SIM/qucs_s
1
0
Fork 0
mirror of https://github.com/ra3xdh/qucs_s synced 2025-03-28 21:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash when new wire ends at the other wire's end

Browse Source
This commit is contained in:
Andrey Kalmykov 2025-02-07 15:53:34 +03:00
parent 6fb5f15c57
commit 8f0fc38487
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qucs/mouseactions.cpp
View File

@ -1493,7 +1493,7 @@ void MouseActions::MPressWire2(Schematic *Doc, QMouseEvent *Event, float fX, flo
case Qt::LeftButton: {
auto [hasChanges, lastNode] = Doc->connectWithWire({MAx3, MAy3}, {MAx2, MAy2});
if (lastNode->conn_count() > 1) {
if (lastNode == nullptr || lastNode->conn_count() > 1) {
// if last port is connected, then...
if (formerAction) {
// ...restore old action

16
qucs/schematic_element.cpp
View File

@ -3271,7 +3271,21 @@ std::pair<bool,Node*> Schematic::connectWithWire(const QPoint& a, const QPoint&
}
}
assert(false); // Must never get there
// If we've got there, then the point at which the wire ended
// was optimized away. For example if there was a wire AB…
//
// A B
// o--------o
//
// And a new wire was drawn from point M to point A:
//
// M A B
// o------o--------o
//
// then two wires wouild be merged and point A would be removed:
//
// M B
// o---------------o
return {resultFlags, nullptr};
}