SIM/qucs_s
1
0
Fork 0
mirror of https://github.com/ra3xdh/qucs_s synced 2025-03-28 21:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add warning comments to Node::connect and Node::disconnect

Browse Source
This commit is contained in:
Andrey Kalmykov 2024-08-02 17:03:12 +02:00
parent fd64753c93
commit e2c540d7f9
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qucs/node.h
View File

@ -74,6 +74,8 @@ private:
std::list<Element*> connections;
};
// Calling this while iterating over the node's connections via Node::begin() and
// Node::end() will cause segfault because of iterator invalidation
inline void Node::connect(Element* connectable)
{
if (is_connected(connectable)) {
@ -82,6 +84,8 @@ inline void Node::connect(Element* connectable)
connections.push_front(connectable);
}
// Calling this while iterating over the node's connections via Node::begin() and
// Node::end() will cause segfault because of iterator invalidation
inline void Node::disconnect(Element* connectable)
{
connections.remove(connectable);