Fix all build warnings/issues

-Unconditional re-build of flex/bison parser by fixing wrong dependencies
-Removed unused code causing compiler warnings
-Removed unused function variables
-Refactor switch-case statements to prevent compiler warnings

Signed-off-by: ThomasZecha <zecha@ihp-microelectronics.com>

converter/CMakeLists.txt

@@ -32,7 +32,7 @@ ENDIF()
 # This is a HACK to get arround a PATH issue with Qt Creator on OSX.
 # It seams impossible to pass a custom PATH to Qt Creator on OSX, ie, cannot prepend `/usr/local/bin/` for intance.
 # The FIND_PACKAGE fails. For now we provide a fallback with a custom FIND_PROGRAM. The variable BISON_DIR is also available.
-FIND_PACKAGE(BISON 2.4 REQUIRED)
+FIND_PACKAGE(BISON 3.0 REQUIRED)
 IF(BISON_FOUND)
   #MESSAGE(STATUS "Found bison: ${BISON_EXECUTABLE} / Version: ${BISON_VERSION}" )
 ENDIF()
@@ -96,7 +96,7 @@ FOREACH( type ${ParserTypes} )
   # Create custom Bison
   SET(BO_${type}
     ${CMAKE_CURRENT_BINARY_DIR}/parse_${type}.cpp
-    ${CMAKE_CURRENT_BINARY_DIR}/tokens_${type}.h )
+    ${CMAKE_CURRENT_BINARY_DIR}/parse_${type}.hpp )
   ADD_CUSTOM_COMMAND(
     OUTPUT ${BO_${type}}
     COMMAND ${BISON_EXECUTABLE}

converter/parse_dataset.ypp

@@ -52,7 +52,7 @@ using namespace qucs;
 
 %}
 
-%name-prefix "dataset_"
+%define api.prefix {dataset_}
 
 %token InvalidCharacter
 %token Identifier

converter/parse_vcd.ypp

@@ -43,7 +43,7 @@
 
 %}
 
-%name-prefix "vcd_"
+%define api.prefix {vcd_}
 
 %token t_END
 %token t_COMMENT

converter/real.cpp

@@ -252,14 +252,6 @@ nr_double_t floor( nr_double_t arg) {
   return std::floor(arg);
 }
 
-nr_double_t fmod( nr_double_t arg) {
-#ifdef HAVE_STD_TRUNC
-  return std::fmod(arg);
-#else
-  return fmod(arg);
-#endif
-}
-
 nr_double_t trunc( nr_double_t arg) {
 #ifdef HAVE_STD_TRUNC
   return std::trunc(arg);

converter/real.h

@@ -88,7 +88,6 @@ nr_double_t erf(const nr_double_t );
 //
 nr_double_t ceil(const nr_double_t );
 nr_double_t floor(const nr_double_t );
-nr_double_t fmod(const nr_double_t ); //FIXME
 nr_double_t trunc(const nr_double_t ); // c++11
 nr_double_t round(const nr_double_t ); // c++11
 

converter/strlist.cpp

@@ -150,22 +150,6 @@ char * strlist::first (void) const {
   return s ? s->str : NULL;
 }
 
-/* The function removes each occurrence of the given string list entry
-   from the string list object. */
-void strlist::del (strlist * cand) {
-  if (cand == NULL) return;
-  struct strlist_t * next;
-  strlist * res = new strlist ();
-  while (root) {
-    next = root->next;
-    if (cand->contains (root->str) == 0) res->append (root->str);
-    free (root->str);
-    free (root);
-    root = next;
-  }
-  *this = *res;
-}
-
 /* The function joins the given string lists to each other and returns
    the resulting list. */
 strlist * strlist::join (strlist * pre, strlist * post) {

converter/strlist.h

@@ -53,7 +53,6 @@ class strlist
   char * last (void) const;
   int index (char *);
   static strlist * join (strlist *, strlist *);
-  void del (strlist *);
   char * toString (const char * concat = " ");
 
  private:

qucs-activefilter/qf_poly.cpp

@@ -1255,8 +1255,6 @@ void qf_poly::to_roots (void) {
     exit (-1);
   }
 
-  int status;
-
   if ((rep == ROOTS) || (rep == BOTH))
     return;			// Nothing to do
 
@@ -1275,7 +1273,7 @@ void qf_poly::to_roots (void) {
 
   qf_scm (m);
   qf_bcm (m);
-  status = qf_qrc (m, rts);
+  qf_qrc (m, rts);
 
   // root solving qr method failed to converge
   for (unsigned i = 0; i < 2 * d; i++) {

qucs-activefilter/schcauer.cpp

@@ -120,7 +120,7 @@ void SchCauer::calcHighPass()
 
 void SchCauer::calcBandPass()
 {
-    double  R1,R2,R3,R4,R5,R6,R7,C1,C2;
+    double  R1,R2,R3,R4,R5,R6,C1,C2;
     double  W0 = 2*pi*F0;
     double  Kv1 = pow(Kv,1.0/order);
     int cnt = 1;
@@ -150,7 +150,6 @@ void SchCauer::calcBandPass()
         R5 = R3;
         R4 = (Kv1/mu)*sqrt(C/A)*R5;
         R6 = mu*R2/(mu-1);
-        R7 = mu*R2;
 
         RC_elements current_section;
         current_section.N = cnt;
@@ -172,7 +171,6 @@ void SchCauer::calcBandPass()
         R5 = R3;
         R4 = (Kv1/mu)*sqrt(C/A)*R5;
         R6 = mu*R2/(mu-1);
-        R7 = mu*R2;
 
         current_section.N = cnt;
         current_section.R1 = 1000*R1;

qucs-attenuator/qucsattenuator.cpp

@@ -239,6 +239,7 @@ void QucsAttenuator::slotQuit()
   tmp = y();
   tmp = width();
   tmp = height();
+  Q_UNUSED(tmp);
 
   qApp->quit();
 }

qucs-filter/qf_poly.cpp

@@ -1255,8 +1255,6 @@ void qf_poly::to_roots (void) {
     exit (-1);
   }
 
-  int status;
-
   if ((rep == ROOTS) || (rep == BOTH))
     return;			// Nothing to do
 
@@ -1275,7 +1273,7 @@ void qf_poly::to_roots (void) {
 
   qf_scm (m);
   qf_bcm (m);
-  status = qf_qrc (m, rts);
+  qf_qrc (m, rts);
 
   // root solving qr method failed to converge
   for (unsigned i = 0; i < 2 * d; i++) {

qucs-filter/qucsfilter.cpp

@@ -307,6 +307,8 @@ QucsFilter::~QucsFilter()
 void QucsFilter::slotQuit()
 {
   int tmp;
+  Q_UNUSED(tmp);
+
   tmp = x();		// call size and position function in order to ...
   tmp = y();		// ... set them correctly before closing the ...
   tmp = width();	// dialog !!!  Otherwise the frame of the window ...

qucs/mouseactions.cpp

@@ -1077,9 +1077,12 @@ void MouseActions::MPressSelect(Schematic *Doc, QMouseEvent *Event, float fX, fl
             return;
 
         case isDiagramHScroll: // scroll in tabular ?
-            MAy1 = MAx1;
-
         case isDiagramVScroll:
+            if (focusElement->Type == isDiagramHScroll)
+            {
+                MAy1 = MAx1;
+            }
+
             focusElement->Type = isDiagram;
 
             No = ((TabDiagram *) focusElement)->scroll(MAy1);
@@ -1799,7 +1802,7 @@ void MouseActions::moveElements(Schematic *Doc, int &x1, int &y1)
 // -----------------------------------------------------------
 void MouseActions::rotateElements(Schematic *Doc, int &x1, int &y1)
 {
-    int x2, y2;
+    int x2;
     Element *pe;
     Doc->setOnGrid(x1, y1);
 

qucs/schematic_file.cpp

@@ -1674,7 +1674,8 @@ void Schematic::createSubNetlistPlain(QTextStream *stream, QPlainTextEdit *ErrTe
             case 'o': // output ports need workaround
               Signals.insert(*it_name, DigSignal(*it_name, *it_type));
               (*it_name) = "net_out" + (*it_name);
-              // no "break;" here !!!
+              (*it_name) += " : " + pc->Props.at(1)->Value;
+              break;
             default:
               (*it_name) += " : " + pc->Props.at(1)->Value;
           }