SIM/qucs_s
1
0
Fork 0
mirror of https://github.com/ra3xdh/qucs_s synced 2025-03-28 21:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix segfault when component is placed over the wire

Browse Source 
See https://github.com/ra3xdh/qucs_s/pull/845#issuecomment-2262938687
This commit is contained in:
Andrey Kalmykov 2024-08-02 16:54:04 +02:00
parent 7e2cf61226
commit fd64753c93
1 changed files with 20 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
qucs/schematic_element.cpp
View File

@ -2544,34 +2544,39 @@ void Schematic::insertComponentNodes(Component *component, bool noOptimize)
if(noOptimize) return;
Node *node;
Node* other_node;
// if component over wire then delete this wire
QListIterator<Port *> iport(component->Ports);
// omit the first element
Port *component_port = iport.next();
std::vector<Wire*> dead_wires;
while (iport.hasNext()) {
component_port = iport.next();
node = component_port->Connection;
for (auto* connected : *node) {
// At first iterate over all port's connections to find wires
// connecting this port to another port of the same component.
for (auto* connected : *component_port->Connection) {
if (connected->Type != isWire) {
continue;
}
if (((Wire*)connected)->Port1 == node) {
other_node = ((Wire*)connected)->Port2;
}
else {
other_node = ((Wire*)connected)->Port1;
}
auto wire = static_cast<Wire*>(connected);
for(auto* other_connection : *other_node) {
if (other_connection == component) {
deleteWire((Wire*)connected);
break;
}
if (wire->Port1->is_connected(component) && wire->Port2->is_connected(component)) {
dead_wires.push_back(wire);
}
}
// Disconnect and remove the wires that have been found earlier.
//
// It must be done while not iterating over the node's connections
// because invocation of disconnect() invalidates the iterator over
// node's connections. In short: calling disconnect() while iterating
// over connections leads to segmentation fault.
for (auto w : dead_wires) {
deleteWire(w);
}
dead_wires.clear();
}
}