Qt6 QTranslator::load() uses [[nodiscard]] which currently leads to
compiler warnings. This is fixed using static_cast<void>.
Signed-off-by: ThomasZecha <zecha@ihp-microelectronics.com>
Before this commit, all traces associated to a S-parameter file were saved in the session file even if the user was not displaying them. This causes a heavy overhead specially in large files.
Now, the session file only contains S-parameter data. If the user wants to display additional traces such as K, mu, |delta|, etc., they are computed on demand
It was found that when a session file is loaded the width of the traces was 1 regardless the trace setting.
The pen width was omitted... This commit fixes this problem.
It was found useful to have a "Recent Files" list with the last 10 sessions, this allows the user to quickly load a session file he/she worked recently.
A simple code editor example provided by Qt [1] was included in the tool. It is very convenient to have a text pad to include comments on the traces displayed.
The notes are saved into the session file and they are restored when a session file is opened.
[1] https://doc.qt.io/qt-5/qtwidgets-widgets-codeeditor-example.html
It was found that after a trace/limit/marker is removed, if the user adds a new trace/limit/marker, the new widgets overlap the last ones.
This happened because the position of the widgets in the QGridLayoyt were not updated after a trace/limit/marker is removed.
This commit addresses this issue.
It was found that before this commit the program had problems to load session files. Specifically, it didn't catch the axes limit and it also had problems if the previous session was saved with the lock status = true
1) The warning is related to a potential performance issue with Qt containers when used in C++11 range-based for loops
"c++11 range-loop might detach Qt container (QList) [clazy-range-loop-detach]"
2) tmp variable unused in exit() function
Remove unneeded CMakeLists in bitmaps folder
Add qucs-s-spar-viewer.icns
This is required for the "build-mac-universal" and "build-mac-intel" jobs
Install libqt5charts5-dev dependency
I set up a fresh Lubuntu 24.04 on a VM and compiled the code from source using the instructions provided in the Qucs-S page. I found that to avoid the above error in the build, you need to install "libqt5charts5-dev" first.
After that the compilation went fine. I'm not sure if it works with "libqt6charts6-dev". I'll check later.
Typo in CMakeLists
Remove unneeded include causing trouble in build appImage-Qt6
/home/runner/work/qucs_s/qucs_s/qucs-s-spar-viewer/main.cpp:28:10: fatal error: QDesktopWidget: No such file or directory
28 | #include <QDesktopWidget>
Missing line in windows build
Patch provided by ra3xdh QtCharts
Update cmake.yml and deploy.yml
Added qt6-charts to Windows build and qt5charts to Qt5 build
This commit contains the first draft of the user interface
Read Touchstone files
It was implemented a basic function to read Touchstone files.
It can only read Touchstone files up to 4 ports and only S-parameter data.
Please see "Touchstone Specification, Version 2.1, ratified January 26 2024 by the IBIS Open Forum": https://ibis.org/touchstone_ver2.1/
Add QScrollArea widgets to the files and traces lists
Large number of files and traces are expected, so there is a need for scrollable areas in the files and traces lists.
Basic plotting structure
Add default behaviour when loading one single s2p
A default behavior is added. When a single s2p file is selected, the program automatically displays S21, S11 and S22
Replace the "Delete" message by a trash image
The delete image was taken from here
https://commons.wikimedia.org/wiki/File:Delete-button.svg
This file is licensed under the Creative Commons Attribution-Share Alike 4.0 International license.
You are free:
to share – to copy, distribute and transmit the work
to remix – to adapt the work
Under the following conditions:
attribution – You must give appropriate credit, provide a link to the license, and indicate if changes were made. You may do so in any reasonable manner, but not in any way that suggests the licensor endorses you or your use.
share alike – If you remix, transform, or build upon the material, you must distribute your contributions under the same or compatible license as the original.
Read Touchstone files with more than two ports
Update traces combobox depending on the selected dataset
If the user has loaded data with different number of ports, the traces combobox must be refreshed each time the user changes the dataset selection. Otherwise, this may cause that the user selects a non existing trace
Fix style in buttons for removing files
The QPushButtons were replaced by QToolButtons. With the QPushButtons the widget was too wide
Fix style in buttons for removing traces
QPushButton was converted into QToolButton
Delete dataset and its traces when the user decides to remove a file
Remove files and traces
Rework on the logic on how to remove datasets and traces
After removing a file, remove the associated widgets
Remove trace from Chart
Update file widget position in the grid after removing
Function handler for changing the color of a trace
Change linestyle depending on the combo selection
Set initial color of the color pickers
Added a spinbox control to control the trace width
It was added a spinbox that controls the width of the traces displayed. This is very convenient when a bunch of traces are being displayed and the user wants to highlight one of them easily
Added function handler for controlling the x-axis
A handler function was added to control the x-axis settings as the user changes the minimum, maximum or the tick interval
Update traces when changing the axis settings
Fix trace plotting refresh
Fix frequency limits when loading a GHz range file
Dockable widgets
Autoadjust y-axis settings
Automatically add K, delta, mu_s, m_p, MAG and MSG traces in S2P files
When a Touchtone file has two ports, the stability metrics are automatically computed and added to the dataset
Add marker table feature
It was added a new dock consisting on a marker table and some widgets for its management
Add dot marker and vertical lines in the QChart
Make case insensitive the frequency scale
Files were found were the frequency scale is all in capital letters. This creates a problem when reading the spar data. This commit fixes this by putting the frequency scale in lower case
Auto adjust x-axis when changing the units
Put x_div values as a ComboBox
It makes no much sense in having a decimal spinbox for defining the tick interval. It leads to decimal ticks. It's better to have a closed list of possible values
y axis tick in combobox
Fix vertical line markers
Fix bad "About Qt" connection
The "About Qt" message was not properly connected. As a consequence, when the user went to "Help-> About Qt..." nothing showed up.
This commit is intended to fix this by connecting the menu with the handler as it's done in the filter design tool
Link S-parameter viewer to Qucs-S
Add Re{Zin}, Im{Zin} traces to s1p and s2p files
Hide y-axis units
It makes no much sense for now to have it since it may happen that the y-axis represent dB, Ohm or simply its unitless (e.g. K, mu, ...)
Fix segfault when removing one single file
In previous commits, it was observed a segfault when removing one single s-par file. This happened because the program was freeing widgets already freed. This situation is avoided by ordering the list of widgets to remove
Autoadjust y-axis
Remove widgets for marker placement
They are actually not needed. The SpinBox and the combo with units just add clutter. The user can set the marker freq once added
Update x-axis limits after removing file
Increase maximum x-ticks
Get suffix using Qt method
This is more robust than the previous approach
Fix frequency scale in markers
Enable drag and drop to open files
Fix segfault when removing file
Readjust frequency limits when dataset has no traces
Fix read touchstone
Files were found whose header contains no !
Fix initial marker step
Fix autoscale y-axis
Prevent docks from closing
It makes no sense the user can close the docks
Solve infinite loop when fmax=3000 [unit]
Implemented button for removing all files on a row
Implement button for removing all markers on a row
