Introduced very basic c++ coding style for the class Schematic and it's
parent-class QucsDoc based on https://google.github.io/styleguide/cppguide.html:
-Prefix class attributes with a_ (much more better readability!)
-Class member initialization via constructor member initialization list
-No public class attributes (where possible with small effort)
Signed-off-by: ThomasZecha <zecha@ihp-microelectronics.com>
In 72f9e461 all temporary files were moved to a dedicated temp files
dir. To store the name of this dir, a new property named "tempFilesDir"
was introduced and all occurences of "QucsHomeDir" in "temporary file"
contexts were replaced by new property. But in one branch of "ifdef"
preprocessor condition the replacement somehow failed, leaving the
old property name. This commit replaces it with correct one.
Fixes ra3xdh#686
With this commit the root path for temporary files produced
by Qucs-S is set to StandardPaths::CacheLocation which is
~/.cache/qucs-s on Linux.
This path is set automatically and can't be changed.
Qucsconv is called when a Spicefile component needs to be netlisted.
The Spice code is converted to the Qucsator format and inserted into the
netlist.
The issue is that path to Qucsconv is by default expected to be in the
same prefix as Qucs.
For testing the schematic->netlist from the command line it is
convenient to tell explicitly where Qucsconv is located.
This patch does a few things:
* Introduce the QUCSCONV environment variable to override the default
path, assume to be the same prefix as Qucs.
Setting QUCSDIR would work just fine, but require a make install first.
TODO update documentation along with issue #240
* Moved the QUCSCONV to main.cpp, where it is set only once with
a newly introduced QucsSettings.Qucsconv variable.
* Replace dialog pop-up on spicefile.cpp by a statusBar message.
Remaining issue: library components also depend on the assumption that
everything is located on the same Qucs prefix. Hence QUCSDIR migh still
be necessary in some cases, as when using command line on in-three Qucs
binary for testing purporses.
In the log.txt file, the simulation output coming from the standard
error stream was prefixed with the "Errors:" header. This has been
corrected to "Errors and Warnings:" since also warnings are sent to
standard error (by qucsator). This is also aligned with the headers
used in the Simulation Messages dialog.
Progress bar changes in qucsator output caused newlines to be printed
in the simulation message output window due to improper usage of
appendPlainText(), which adds newlines also with empty text.
When checking the exitStatus of a QProcess, negative exit codes are
erroneously interpreted as "program crashed" on Windows, see
https://bugreports.qt.io/browse/QTBUG-28735 .
This has been fixed only in Qt5.1, so we need to apply a workaround
for Qt4 to correctly handle this case.
QPlainTextEdit is better suited to handle large log files, as can result
from large simulations, when debug is enabled, when using the optimizer,
etc. It has also the advantage to automatically show the last messages
and to handle user scrolling of text nicely.
- Program does not neccesary point to a file
- .state is unavailable before WaitForStarted
(don't know how to do asynchronously, add callback?)
- more expressive error message
Changed slotSimEnded() to check the exit status of the simulator
process, so that the user is informed thru the simulation dialog
when the simulator has crashed.
Replaced some Qt3 compatibility functions with the proper Qt4 ones.
Added newlines at the end of the error messages.
Added some Doxygen style comments.
SET( QT_USE_QT3SUPPORT TRUE ) is delete from all CmakeLists.txt and adapting the souces, but "FIND_PACKAGE( Qt4 4.6.3 REQUIRED QtCore QtGui Qt3Support QtSvg QtXml QtScript)" in the root-CMakeLists.txt is unchanged. So Q3*-Header like Q3PtrList will not produce an error.
