Introduced very basic c++ coding style for the class Schematic and it's
parent-class QucsDoc based on https://google.github.io/styleguide/cppguide.html:
-Prefix class attributes with a_ (much more better readability!)
-Class member initialization via constructor member initialization list
-No public class attributes (where possible with small effort)
Signed-off-by: ThomasZecha <zecha@ihp-microelectronics.com>
'drawn' is some obscure flag which is scattered all around
the codebase, it's mostly set to 'false' and only occasionally
to 'true'. It controls blocks of code which are described as
"erase old symbol".
Honestly, I tried to grasp it's meaning and purpose, and I failed.
I believe this flag is just a legacy no one can remember of, and
it's OK to remove it.
Removing 'MouseActions::drawn' completely doesn't seem to change
something, at least at first sight everything looks the same as
usual.
I cram everything in a single large commit for the sake of easier
reverting if it will be needed later.
The 'paint' function of ID_text missed the restore() call on painter,
which led to carrying the changes made to painter further down the
call chain. In other words, the painter state *after* painting the
ID_text wasn't the same as *before* doing it, and everything painted
after the ID_text was affected by this change in painter's state.
This commit add missing restore() call.
Fixes: ra3xdh/qucs_s#739
After switching everything to drawing using bare QPainter, a lot
of ViewPainter-based stuff became unused and basically obsolete,
including the ViewPainter itself.
"Insert port" tool is reused it. When in symbol editing mode,
left mouse button click with this tool activated spawns a dialog
asking for port name, then insert a port.
I hope there is no breaking changes and everything is backwards
compatible as I strived to add workarounds everywhere it's needed.
The sad part is that code is not elegant, it increases overall
codebase entropy, doesn't follow any general strategy. It's just
a set of patches.
- PortSymbol has two members: nameStr and numberStr.
- nameStr is usually empty and is set from Schematic::adjustPortNumber
after performing some obscure checks.
- numberStr is usually contains a number
- PortSymbol::paint outputs 'nameStr' as ports "label"
- When editing a *.sym file, 'adjustPortNumber' is not called,
nameStr remains empty
This patch makes PortSymbol use 'numberStr' as fallback value for
cases when 'nameStr' is empty. When editing a *.sym file one won't
see a port without label anymore.
In sway tiling window manager these dialogs appear as maximized
top-level windows. Setting schematic pointer as parent makes them
appear as normal floating dialogs.
There is not reason we were adding CMAKE_SOURCE_DIR, however it was
breaking building on case insensitive FS e.g. macOS when looking for
<version> header.
