c/libuv
1
0
Fork 0
mirror of https://github.com/libuv/libuv synced 2025-03-28 21:13:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: address FreeBSD kernel bug causing NULL path in fsevents (#4649)

Browse Source 
This commit documents a FreeBSD kernel issue where uv_fs_event can
receive a NULL filename and updates test-fs-event.c to skip filename
assertions on FreeBSD.

* Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197695

Refs: https://github.com/libuv/libuv/issues/4606

Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
This commit is contained in:
Juan José 2024-12-13 15:30:17 -05:00 committed by GitHub
parent 88201044ed
commit acebb97490
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/src/fs_event.rst
View File

@ -47,6 +47,11 @@ Data types
The `events` parameter is an ORed mask of :c:enum:`uv_fs_event` elements. The `events` parameter is an ORed mask of :c:enum:`uv_fs_event` elements.
.. note::
For FreeBSD path could sometimes be `NULL` due to a kernel bug.
.. _Reference: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197695
.. c:enum:: uv_fs_event .. c:enum:: uv_fs_event
Event types that :c:type:`uv_fs_event_t` handles monitor. Event types that :c:type:`uv_fs_event_t` handles monitor.

7
test/test-fs-event.c
View File

@ -153,7 +153,14 @@ static void fs_event_cb_del_dir(uv_fs_event_t* handle,
ASSERT_PTR_EQ(handle, &fs_event); ASSERT_PTR_EQ(handle, &fs_event);
ASSERT_OK(status); ASSERT_OK(status);
ASSERT(events == UV_CHANGE || events == UV_RENAME); ASSERT(events == UV_CHANGE || events == UV_RENAME);
/* There is a bug in the FreeBSD kernel where the filename is sometimes NULL.
* Refs: https://github.com/libuv/libuv/issues/4606
*/
#if defined(__FreeBSD__)
ASSERT(filename == NULL || strcmp(filename, "watch_del_dir") == 0);
#else
ASSERT_OK(strcmp(filename, "watch_del_dir")); ASSERT_OK(strcmp(filename, "watch_del_dir"));
#endif
ASSERT_OK(uv_fs_event_stop(handle)); ASSERT_OK(uv_fs_event_stop(handle));
uv_close((uv_handle_t*)handle, close_cb); uv_close((uv_handle_t*)handle, close_cb);
} }