c/libuv
1
0
Fork 0
mirror of https://github.com/libuv/libuv synced 2025-03-28 21:13:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

unix,win: reset the timer queue on stop (#4304)

Browse Source 
As there were instances where this didn't happen and could cause memory
corruption issues.

Refs: https://github.com/libuv/libuv/issues/4248
This commit is contained in:
Santiago Gimeno 2024-02-07 10:43:29 +01:00 committed by GitHub
parent 10f313631c
commit bb6fbcf6e7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/timer.c
View File

@ -94,20 +94,18 @@ int uv_timer_start(uv_timer_t* handle,
return 0;
}
static void timer_stop(uv_timer_t* handle) {
heap_remove(timer_heap(handle->loop),
(struct heap_node*) &handle->node.heap,
timer_less_than);
uv__handle_stop(handle);
uv__queue_init(&handle->node.queue);
}
int uv_timer_stop(uv_timer_t* handle) {
if (uv__is_active(handle))
timer_stop(handle);
else
if (uv__is_active(handle)) {
heap_remove(timer_heap(handle->loop),
(struct heap_node*) &handle->node.heap,
timer_less_than);
uv__handle_stop(handle);
} else {
uv__queue_remove(&handle->node.queue);
}
uv__queue_init(&handle->node.queue);
return 0;
}
@ -181,7 +179,7 @@ void uv__run_timers(uv_loop_t* loop) {
if (handle->timeout > loop->time)
break;
timer_stop(handle);
uv_timer_stop(handle);
uv__queue_insert_tail(&ready_queue, &handle->node.queue);
}