mirror of
https://github.com/libuv/libuv
synced 2025-03-28 21:13:16 +00:00
fa1da18549
Commit ff29322b ("test: canonicalize test runner path") from 2014
changed the test runner to call `realpath(3)` on `argv[0]` in order
to fix the `get_currentexe` test failing with the autotools build when
the executable path contained symbolic links but that is now causing
the `spawn_reads_child_path` test to fail on z/os with the cmake build.
Fix that by only doing path canonicalization in the `get_currentexe`
test, not always.
An auxiliary fix is applied to the `process_title_threadsafe` test
because it assumed that setting the process title to a long string,
then reading it back produces in the original string.
On some platforms however the maximum size of the process title is
limited to the size of the `argv` vector.
Because the test runner used absolute paths until now, the argv vector
was bigger than it is with relative paths, big enough to let this bad
assumption go unnoticed until now.
Minor fixes are applied to tests that assumed 1024 for the maximum
path size because this commit makes visible that some of the CI matrix
systems support much longer paths.
PR-URL: https://github.com/libuv/libuv/pull/2755
Refs: https://github.com/libuv/libuv/pull/2737#issuecomment-602800431
Refs: https://github.com/libuv/libuv/pull/2754#issuecomment-604015785
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
83 lines
2.5 KiB
C
83 lines
2.5 KiB
C
/* Copyright libuv project contributors. All rights reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to
|
|
* deal in the Software without restriction, including without limitation the
|
|
* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
|
|
* sell copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include "uv.h"
|
|
#include "task.h"
|
|
#include <string.h>
|
|
|
|
#define PATHMAX 4096
|
|
#define SMALLPATH 1
|
|
|
|
TEST_IMPL(tmpdir) {
|
|
char tmpdir[PATHMAX];
|
|
size_t len;
|
|
char last;
|
|
int r;
|
|
|
|
/* Test the normal case */
|
|
len = sizeof tmpdir;
|
|
tmpdir[0] = '\0';
|
|
|
|
ASSERT(strlen(tmpdir) == 0);
|
|
r = uv_os_tmpdir(tmpdir, &len);
|
|
ASSERT(r == 0);
|
|
ASSERT(strlen(tmpdir) == len);
|
|
ASSERT(len > 0);
|
|
ASSERT(tmpdir[len] == '\0');
|
|
|
|
if (len > 1) {
|
|
last = tmpdir[len - 1];
|
|
#ifdef _WIN32
|
|
ASSERT(last != '\\');
|
|
#else
|
|
ASSERT(last != '/');
|
|
#endif
|
|
}
|
|
|
|
/* Test the case where the buffer is too small */
|
|
len = SMALLPATH;
|
|
r = uv_os_tmpdir(tmpdir, &len);
|
|
ASSERT(r == UV_ENOBUFS);
|
|
ASSERT(len > SMALLPATH);
|
|
|
|
/* Test invalid inputs */
|
|
r = uv_os_tmpdir(NULL, &len);
|
|
ASSERT(r == UV_EINVAL);
|
|
r = uv_os_tmpdir(tmpdir, NULL);
|
|
ASSERT(r == UV_EINVAL);
|
|
len = 0;
|
|
r = uv_os_tmpdir(tmpdir, &len);
|
|
ASSERT(r == UV_EINVAL);
|
|
|
|
#ifdef _WIN32
|
|
const char *name = "TMP";
|
|
char tmpdir_win[] = "C:\\xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx";
|
|
r = uv_os_setenv(name, tmpdir_win);
|
|
ASSERT(r == 0);
|
|
char tmpdirx[PATHMAX];
|
|
size_t lenx = sizeof tmpdirx;
|
|
r = uv_os_tmpdir(tmpdirx, &lenx);
|
|
ASSERT(r == 0);
|
|
#endif
|
|
|
|
return 0;
|
|
}
|