c/libxlsxwriter
1
0
Fork 0
mirror of https://github.com/jmcnamara/libxlsxwriter synced 2025-03-28 21:13:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for buffer overflow with utf-8 strings in data validation.

Browse Source 
Fix for buffer overflow with utf-8 strings in data validation
list.

Closes #394
This commit is contained in:
John McNamara 2023-02-22 13:10:20 +00:00
parent 5c5b3046af
commit bd91a72223
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/worksheet.c
View File

@ -1460,7 +1460,7 @@ _validation_list_length(char **list)
if (!list || !list[0])
return 0;
while (list[i] && length <= LXW_VALIDATION_MAX_STRING_LENGTH) {
while (list[i] && length < LXW_VALIDATION_MAX_STRING_LENGTH) {
/* Include commas in the length. */
length += 1 + lxw_utf8_strlen(list[i]);
i++;
@ -1481,8 +1481,8 @@ _validation_list_to_csv(char **list)
char *str;
/* Create a buffer for the concatenated, and quoted, string. */
/* Add +3 for quotes and EOL. */
str = calloc(1, LXW_VALIDATION_MAX_STRING_LENGTH + 3);
/* Allow for 4 byte UTF-8 chars and add 3 bytes for quotes and EOL. */
str = calloc(1, LXW_VALIDATION_MAX_STRING_LENGTH * 4 + 3);
if (!str)
return NULL;