From 2fcdc5f7e7e60926e900d1c0e5d36b8176d14199 Mon Sep 17 00:00:00 2001 From: Nick Wellnhofer Date: Mon, 18 Nov 2024 20:41:09 +0100 Subject: [PATCH] globals: More comments on future directions --- globals.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/globals.c b/globals.c index 05bc8ed1..28ec3d31 100644 --- a/globals.c +++ b/globals.c @@ -58,12 +58,20 @@ static xmlMutex xmlThrDefMutex; * On Windows, we either use DllMain when compiling a DLL or a registered * wait function for static builds. * - * Compiler TLS isn't really useful. It can make allocation more robust - * on some platforms but it also increases the memory consumption of each - * thread by ~250 bytes whether it uses libxml2 or not. The main problem - * is that be have to deallocate strings in xmlLastError and C offers no - * simple way to deallocate dynamic data in _Thread_local variables. - * In C++, one could simply use a thread_local variable with a destructor. + * Compiler TLS isn't really useful for now. It can make allocation more + * robust on some platforms but it also increases the memory consumption + * of each thread by ~250 bytes whether it uses libxml2 or not. The main + * problem is that we have to deallocate strings in xmlLastError and C + * offers no simple way to deallocate dynamic data in _Thread_local + * variables. In C++, one could simply use a thread_local variable with a + * destructor. + * + * At some point, many of the deprecated globals can be removed, + * although things like global error handlers will take a while. + * Ultimately, the only crucial things seem to be xmlLastError and + * RNG state. xmlLastError already involves dynamic allocation, so it + * could be allocated dynamically as well, only storing a global + * pointer. */ #ifdef LIBXML_THREAD_ENABLED