c/libxml2
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libxml2 synced 2025-03-28 21:33:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixed the leak reported by Volker Roth on the list added a specific test

Browse Source 
* parser.c: fixed the leak reported by Volker Roth on the list
* test/ent10 result//ent10*: added a specific test for the problem
Daniel
This commit is contained in:
Daniel Veillard 2004-10-25 16:23:56 +00:00
parent 367df6e7e1
commit 370ba3d231
10 changed files with 119 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
Mon Oct 25 17:11:37 CEST 2004 Daniel Veillard <daniel@veillard.com>
* parser.c: fixed the leak reported by Volker Roth on the list
* test/ent10 result//ent10*: added a specific test for the problem
Sat Oct 23 11:07:41 PDT 2004 William Brack <wbrack@mmm.com.hk> Sat Oct 23 11:07:41 PDT 2004 William Brack <wbrack@mmm.com.hk>
* valid.c: unlinked the internal subset within xmlValidateDtd * valid.c: unlinked the internal subset within xmlValidateDtd

2
error.c
View File

@ -453,7 +453,7 @@ __xmlRaiseError(xmlStructuredErrorFunc schannel,
return; return;
if ((domain == XML_FROM_PARSER) || (domain == XML_FROM_HTML) || if ((domain == XML_FROM_PARSER) || (domain == XML_FROM_HTML) ||
(domain == XML_FROM_DTD) || (domain == XML_FROM_NAMESPACE) || (domain == XML_FROM_DTD) || (domain == XML_FROM_NAMESPACE) ||
(domain == XML_FROM_IO)) { (domain == XML_FROM_IO) || (domain == XML_FROM_VALID)) {
ctxt = (xmlParserCtxtPtr) ctx; ctxt = (xmlParserCtxtPtr) ctx;
if ((schannel == NULL) && (ctxt != NULL) && (ctxt->sax != NULL) && if ((schannel == NULL) && (ctxt != NULL) && (ctxt->sax != NULL) &&
(ctxt->sax->initialized == XML_SAX2_MAGIC)) (ctxt->sax->initialized == XML_SAX2_MAGIC))

8
parser.c
View File

@ -5692,16 +5692,20 @@ xmlParseReference(xmlParserCtxtPtr ctxt) {
xmlAddEntityReference(ent, firstChild, nw); xmlAddEntityReference(ent, firstChild, nw);
#endif /* LIBXML_LEGACY_ENABLED */ #endif /* LIBXML_LEGACY_ENABLED */
} else { } else {
const xmlChar *nbktext;
/* /*
* the name change is to avoid coalescing of the * the name change is to avoid coalescing of the
* node with a possible previous text one which * node with a possible previous text one which
* would make ent->children a dangling pointer * would make ent->children a dangling pointer
*/ */
nbktext = xmlDictLookup(ctxt->dict, BAD_CAST "nbktext",
-1);
if (ent->children->type == XML_TEXT_NODE) if (ent->children->type == XML_TEXT_NODE)
ent->children->name = xmlStrdup(BAD_CAST "nbktext"); ent->children->name = nbktext;
if ((ent->last != ent->children) && if ((ent->last != ent->children) &&
(ent->last->type == XML_TEXT_NODE)) (ent->last->type == XML_TEXT_NODE))
ent->last->name = xmlStrdup(BAD_CAST "nbktext"); ent->last->name = nbktext;
xmlAddChildList(ctxt->node, ent->children); xmlAddChildList(ctxt->node, ent->children);
} }

14
result/ent10 Normal file
View File

@ -0,0 +1,14 @@
<?xml version="1.0" encoding="ISO-8859-1"?>
<!DOCTYPE rnode [
<!ELEMENT rnode (f)>
<!ELEMENT f (#PCDATA)>
<!ATTLIST f att1 CDATA #FIXED "J">
<!ENTITY f "
<f>
hello world
</f>
">
]>
<rnode>
&f;
</rnode>

14
result/ent10.rde Normal file
View File

@ -0,0 +1,14 @@
0 10 rnode 0 0
0 1 rnode 0 0
1 14 #text 0 1
1 1 f 0 0
2 3 #text 0 1
hello world
1 15 f 0 0
1 14 #text 0 1
0 15 rnode 0 0

8
result/ent10.rdr Normal file
View File

@ -0,0 +1,8 @@
0 10 rnode 0 0
0 1 rnode 0 0
1 14 #text 0 1
1 5 f 0 0
1 14 #text 0 1
0 15 rnode 0 0

31
result/ent10.sax Normal file
View File

@ -0,0 +1,31 @@
SAX.setDocumentLocator()
SAX.startDocument()
SAX.internalSubset(rnode, , )
SAX.elementDecl(rnode, 4, ...)
SAX.elementDecl(f, 3, ...)
SAX.attributeDecl(f, att1, 1, 4, J, ...)
SAX.entityDecl(f, 1, (null), (null),
<f>
hello world
</f>
)
SAX.getEntity(f)
SAX.externalSubset(rnode, , )
SAX.startElement(rnode)
SAX.characters(
, 4)
SAX.getEntity(f)
SAX.ignorableWhitespace(
, 4)
SAX.startElement(f)
SAX.characters(
hello world
, 19)
SAX.endElement(f)
SAX.characters(
, 4)
SAX.reference(f)
SAX.characters(
, 1)
SAX.endElement(rnode)
SAX.endDocument()

18
result/noent/ent10 Normal file
View File

@ -0,0 +1,18 @@
<?xml version="1.0" encoding="ISO-8859-1"?>
<!DOCTYPE rnode [
<!ELEMENT rnode (f)>
<!ELEMENT f (#PCDATA)>
<!ATTLIST f att1 CDATA #FIXED "J">
<!ENTITY f "
<f>
hello world
</f>
">
]>
<rnode>
<f>
hello world
</f>
</rnode>

21
test/ent10 Normal file
View File

@ -0,0 +1,21 @@
<?xml version="1.0" encoding="ISO-8859-1" ?>
<!DOCTYPE rnode [
<!ELEMENT rnode (f)>
<!ELEMENT f (#PCDATA)>
<!ATTLIST f
att1 CDATA #FIXED 'J'>
<!ENTITY f
"
<f>
hello world
</f>
"
>
]>
<rnode>
&f;
</rnode>

2
tree.c
View File

@ -5081,7 +5081,7 @@ xmlNodeSetContent(xmlNodePtr cur, const xmlChar *content) {
case XML_COMMENT_NODE: case XML_COMMENT_NODE:
if (cur->content != NULL) { if (cur->content != NULL) {
if (!((cur->doc != NULL) && (cur->doc->dict != NULL) && if (!((cur->doc != NULL) && (cur->doc->dict != NULL) &&
xmlDictOwns(cur->doc->dict, cur->content))) (!xmlDictOwns(cur->doc->dict, cur->content))))
xmlFree(cur->content); xmlFree(cur->content);
} }
if (cur->children != NULL) xmlFreeNodeList(cur->children); if (cur->children != NULL) xmlFreeNodeList(cur->children);