c/libxml2
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libxml2 synced 2025-03-28 21:33:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix early return in vstateVPush in valid.c

Browse Source 
While looking over the code in the fallback method for `vstateVPush` in
valid.c when `LIBXML_REGEXP_ENABLED` is not defined, I noticed that
there is an ungated `return(-1)` after attempting to allocate memory.

I believe this should be inside a check, for if the malloc fails.
This commit is contained in:
Zak Ridouh 2025-02-05 14:11:04 -08:00
parent 62d4697db6
commit b466e70ae5
Failed to extract signature
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
valid.c
View File

@ -315,7 +315,10 @@ vstateVPush(xmlValidCtxtPtr ctxt, xmlElementContentPtr cont,
newSize = xmlGrowCapacity(ctxt->vstateMax, sizeof(tmp[0]),
8, MAX_RECURSE);
return(-1);
if (newSize < 0) {
xmlVErrMemory(ctxt);
return(-1);
}
tmp = xmlRealloc(ctxt->vstateTab, newSize * sizeof(tmp[0]));
if (tmp == NULL) {
xmlVErrMemory(ctxt);
@ -6995,4 +6998,3 @@ xmlValidGetValidElements(xmlNode *prev, xmlNode *next, const xmlChar **names,
return(nb_valid_elements);
}
#endif /* LIBXML_VALID_ENABLED */