c/libxml2
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libxml2 synced 2025-03-28 21:33:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

malloc-fail: Fix memory leak in xmlXPathDistinctSorted

Browse Source 
Found with libFuzzer, see #344.
This commit is contained in:
Nick Wellnhofer 2023-02-26 18:00:30 +01:00
parent 6f9604f0e3
commit bc9f372c10
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
xpath.c
View File

@ -4560,16 +4560,23 @@ xmlXPathDistinctSorted (xmlNodeSetPtr nodes) {
cur = xmlXPathNodeSetItem(nodes, i);
strval = xmlXPathCastNodeToString(cur);
if (xmlHashLookup(hash, strval) == NULL) {
xmlHashAddEntry(hash, strval, strval);
/* TODO: Propagate memory error. */
if (xmlHashAddEntry(hash, strval, strval) < 0) {
xmlFree(strval);
goto error;
}
if (xmlXPathNodeSetAddUnique(ret, cur) < 0)
break;
goto error;
} else {
xmlFree(strval);
}
}
xmlHashFree(hash, xmlHashDefaultDeallocator);
return(ret);
error:
xmlHashFree(hash, xmlHashDefaultDeallocator);
xmlXPathFreeNodeSet(ret);
return(NULL);
}
/**