c/libxml2
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libxml2 synced 2025-03-28 21:33:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

save: Report more malloc failures

Browse Source
This commit is contained in:
Nick Wellnhofer 2024-01-02 21:49:43 +01:00
parent 2c9cd0b68b
commit ca5965d594
1 changed files with 29 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
xmlsave.c
View File

@ -58,8 +58,10 @@ struct _xmlSaveCtxt {
* Handle an out of memory condition * Handle an out of memory condition
*/ */
static void static void
xmlSaveErrMemory(void) xmlSaveErrMemory(xmlOutputBufferPtr out)
{ {
if (out != NULL)
out->error = XML_ERR_NO_MEMORY;
xmlRaiseMemoryError(NULL, NULL, NULL, XML_FROM_OUTPUT, NULL); xmlRaiseMemoryError(NULL, NULL, NULL, XML_FROM_OUTPUT, NULL);
} }
@ -72,11 +74,24 @@ xmlSaveErrMemory(void)
* Handle an out of memory condition * Handle an out of memory condition
*/ */
static void static void
xmlSaveErr(int code, xmlNodePtr node, const char *extra) xmlSaveErr(xmlOutputBufferPtr out, int code, xmlNodePtr node,
const char *extra)
{ {
const char *msg = NULL; const char *msg = NULL;
int res; int res;
/* Don't overwrite memory errors */
if ((out != NULL) && (out->error == XML_ERR_NO_MEMORY))
return;
if (code == XML_ERR_NO_MEMORY) {
xmlSaveErrMemory(out);
return;
}
if (out != NULL)
out->error = code;
switch(code) { switch(code) {
case XML_SAVE_NOT_UTF8: case XML_SAVE_NOT_UTF8:
msg = "string is not in UTF-8\n"; msg = "string is not in UTF-8\n";
@ -99,7 +114,7 @@ xmlSaveErr(int code, xmlNodePtr node, const char *extra)
extra, NULL, NULL, 0, 0, extra, NULL, NULL, 0, 0,
msg, extra); msg, extra);
if (res < 0) if (res < 0)
xmlSaveErrMemory(); xmlSaveErrMemory(out);
} }
/************************************************************************ /************************************************************************
@ -315,7 +330,7 @@ xmlNewSaveCtxt(const char *encoding, int options)
ret = (xmlSaveCtxtPtr) xmlMalloc(sizeof(xmlSaveCtxt)); ret = (xmlSaveCtxtPtr) xmlMalloc(sizeof(xmlSaveCtxt));
if (ret == NULL) { if (ret == NULL) {
xmlSaveErrMemory(); xmlSaveErrMemory(NULL);
return ( NULL ); return ( NULL );
} }
memset(ret, 0, sizeof(xmlSaveCtxt)); memset(ret, 0, sizeof(xmlSaveCtxt));
@ -326,10 +341,7 @@ xmlNewSaveCtxt(const char *encoding, int options)
res = xmlOpenCharEncodingHandler(encoding, /* output */ 1, res = xmlOpenCharEncodingHandler(encoding, /* output */ 1,
&ret->handler); &ret->handler);
if (ret->handler == NULL) { if (ret->handler == NULL) {
if (res < 0) xmlSaveErr(NULL, res, NULL, encoding);
xmlSaveErrMemory();
else
xmlSaveErr(XML_SAVE_UNKNOWN_ENCODING, NULL, encoding);
xmlFreeSaveCtxt(ret); xmlFreeSaveCtxt(ret);
return(NULL); return(NULL);
} }
@ -495,19 +507,14 @@ static int xmlSaveSwitchEncoding(xmlSaveCtxtPtr ctxt, const char *encoding) {
int res; int res;
res = xmlOpenCharEncodingHandler(encoding, /* output */ 1, &handler); res = xmlOpenCharEncodingHandler(encoding, /* output */ 1, &handler);
if (res != 0) { if (handler == NULL) {
if (res < 0) xmlSaveErr(buf, res, NULL, encoding);
xmlSaveErrMemory();
else
xmlSaveErr(XML_SAVE_UNKNOWN_ENCODING, NULL, encoding);
buf->error = res;
return(-1); return(-1);
} }
buf->conv = xmlBufCreate(); buf->conv = xmlBufCreate();
if (buf->conv == NULL) { if (buf->conv == NULL) {
xmlCharEncCloseFunc(handler); xmlCharEncCloseFunc(handler);
xmlSaveErrMemory(); xmlSaveErrMemory(buf);
buf->error = XML_ERR_NO_MEMORY;
return(-1); return(-1);
} }
buf->encoder = handler; buf->encoder = handler;
@ -2155,7 +2162,7 @@ xmlBufNodeDump(xmlBufPtr buf, xmlDocPtr doc, xmlNodePtr cur, int level,
} }
outbuf = (xmlOutputBufferPtr) xmlMalloc(sizeof(xmlOutputBuffer)); outbuf = (xmlOutputBufferPtr) xmlMalloc(sizeof(xmlOutputBuffer));
if (outbuf == NULL) { if (outbuf == NULL) {
xmlSaveErrMemory(); xmlSaveErrMemory(NULL);
return (-1); return (-1);
} }
memset(outbuf, 0, (size_t) sizeof(xmlOutputBuffer)); memset(outbuf, 0, (size_t) sizeof(xmlOutputBuffer));
@ -2198,13 +2205,11 @@ xmlElemDump(FILE * f, xmlDocPtr doc, xmlNodePtr cur)
outbuf = xmlOutputBufferCreateFile(f, NULL); outbuf = xmlOutputBufferCreateFile(f, NULL);
if (outbuf == NULL) if (outbuf == NULL)
return; return;
if ((doc != NULL) && (doc->type == XML_HTML_DOCUMENT_NODE)) {
#ifdef LIBXML_HTML_ENABLED #ifdef LIBXML_HTML_ENABLED
if ((doc != NULL) && (doc->type == XML_HTML_DOCUMENT_NODE))
htmlNodeDumpOutput(outbuf, doc, cur, NULL); htmlNodeDumpOutput(outbuf, doc, cur, NULL);
#else else
xmlSaveErr(XML_ERR_INTERNAL_ERROR, cur, "HTML support not compiled in\n");
#endif /* LIBXML_HTML_ENABLED */ #endif /* LIBXML_HTML_ENABLED */
} else
xmlNodeDumpOutput(outbuf, doc, cur, 0, 1, NULL); xmlNodeDumpOutput(outbuf, doc, cur, 0, 1, NULL);
xmlOutputBufferClose(outbuf); xmlOutputBufferClose(outbuf);
} }
@ -2326,17 +2331,13 @@ xmlDocDumpFormatMemoryEnc(xmlDocPtr out_doc, xmlChar **doc_txt_ptr,
res = xmlOpenCharEncodingHandler(txt_encoding, /* output */ 1, res = xmlOpenCharEncodingHandler(txt_encoding, /* output */ 1,
&conv_hdlr); &conv_hdlr);
if (conv_hdlr == NULL) { if (conv_hdlr == NULL) {
if (res < 0) xmlSaveErr(NULL, res, NULL, txt_encoding);
xmlSaveErrMemory();
else
xmlSaveErr(XML_SAVE_UNKNOWN_ENCODING, (xmlNodePtr) out_doc,
txt_encoding);
return; return;
} }
} }
if ((out_buff = xmlAllocOutputBuffer(conv_hdlr)) == NULL ) { if ((out_buff = xmlAllocOutputBuffer(conv_hdlr)) == NULL ) {
xmlSaveErrMemory(); xmlSaveErrMemory(NULL);
xmlCharEncCloseFunc(conv_hdlr); xmlCharEncCloseFunc(conv_hdlr);
return; return;
} }
@ -2370,7 +2371,7 @@ xmlDocDumpFormatMemoryEnc(xmlDocPtr out_doc, xmlChar **doc_txt_ptr,
return; return;
error: error:
xmlSaveErrMemory(); xmlSaveErrMemory(NULL);
xmlOutputBufferClose(out_buff); xmlOutputBufferClose(out_buff);
return; return;
} }