zlib's minizip has SONAME 1. MZ_COMPAT intends to provide ABI and API compatibility,
so its SONAME should match.
The layout with this is:
```
libminizip.so -> libminizip.so.1
libminizip.so.1 -> libminizip.so.4.0.0
libminizip.so.4.0.0
```
Signed-off-by: Sam James <sam@gentoo.org>
Setting _POSIX_C_SOURCE on OpenBSD breaks the build. _BSD_SOURCE needs
to be set at the same time to enable some functions.
In file included from /home/brad/tmp/ffmpeg-ports/ports/pobj/minizip-4.0.0/minizip-ng-4.0.0/test/test_main.cc:5:
In file included from /usr/local/include/gtest/gtest.h:55:
In file included from /usr/include/c++/v1/ostream:140:
In file included from /usr/include/c++/v1/locale:218:
/usr/include/c++/v1/__bsd_locale_fallbacks.h:122:17: error: use of undeclared identifier 'vasprintf'; did you mean 'vsprintf'?
int __res = vasprintf(__s, __format, __va);
^
/usr/include/c++/v1/cstdio:124:9: note: 'vsprintf' declared here
using ::vsprintf _LIBCPP_USING_IF_EXISTS;
^
In file included from /home/brad/tmp/ffmpeg-ports/ports/pobj/minizip-4.0.0/minizip-ng-4.0.0/test/test_main.cc:5:
In file included from /usr/local/include/gtest/gtest.h:55:
In file included from /usr/include/c++/v1/ostream:140:
In file included from /usr/include/c++/v1/locale:218:
/usr/include/c++/v1/__bsd_locale_fallbacks.h:122:27: error: cannot initialize a parameter of type 'char *' with an lvalue of type 'char **'
int __res = vasprintf(__s, __format, __va);
^~~
/usr/include/stdio.h:269:21: note: passing argument to parameter here
int vsprintf(char *, const char *, __va_list);
^
2 errors generated.
Using `cmake_dependent_option` overrides a previously set directory
scope MZ_FETCH_LIBS variable. This means if a project sets MZ_FETCH_LIBS
before adding minizip-ng as a subdirectory in order to force it to fetch
zlib, it will set the variable to OFF, only use `find_library` and never
fetch zlib on non-WIN32 systems. This is a regression from previous
behaviour.
Instead, revert back to using `option` as this obeys a directory scope
MZ_FETCH_LIBS variable set by a parent directory, allowing said parent
directory to control zlib version.
Non-UNIX platforms may support POSIX, partly or fully, through a
compatibility layer of some kind. If a non-Windows platform does not
have the UNIX CMake variable set, take the POSIX path through the CMake
anyway.
The current `liblzma` makes linke look for `libliblzma` as the `lib` prefix is added automatically. This is breaking static linking of library when using pkg-config for resolving dependencies.
When running ctest it also builds and runs example and example64 from zlib.
The GCC CI builds were failing because example and example64 could not find
the header file zlib.h.
Fix the following build failure without a working C++ compiler raised
since version 2.0.0 and
d383a5f2fc:
CMake Error at /nvmedata/autobuild/instance-20/output-1/host/share/cmake-3.18/Modules/CMakeTestCXXCompiler.cmake:59 (message):
The C++ compiler
"/usr/bin/c++"
is not able to compile a simple test program.
Fixes:
- http://autobuild.buildroot.org/results/4452bc35b41414a5e8a0e9831b0854228df5fba4
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
