The release of C++17 has been 5 years ago. The supported period of C++14 has ended and the minimum required C++ version will be increased to C++17 for building the library and using it.
Update decoding and encoding for custom stride
Not all bytes are used in the last line when decoding\encoding with a custom stride.
Take this into account for the destination size computation and the destination size check.
and also for the source buffer check during encoding.
To support platform neutral adapters like Java, Python and C# that need to load depending on the platform different versions, CharLS uses different filenames on Windows. Extend this option for the ARM64 architecture.
CharLS doesn't support mixing interleave modes.
Add a unit test to ensure that CharLS will throw a not supported exception.
The actual checking was already done.
Note: also resolve some static analyzer warnings, reported with the latest version of ReSharper\clang-tidy.
The bytes_per_plane value was using the default stride and not the passed custom stride.
For multi component images with interleave mode none this caused the second plane
to overwrite part of the first decoded plane, etc.
Also added a check to verify the passed stride argument, it should minimal be the default stride.
The destructor of std::ofstream will close the stream, but not report any failures (by design).
Call close to trigger an exception when the close fails.
static_cast for constant values can be replaced with uniform initialization, this allows
to reduce the number of static_casts.
Change the bin+intermediate to be sub-directories of build for MSBuild builds.
This makes it easier to clean.
- Using a private namespace makes it possible to prevent that the helper functions are in the charls namespace.
- As encoding_options is used as a flag enum it makes more sense to use an unsigned type (with well defined behaviour for bitwise operations)
- Using the same type helps ReSharper to match the definition and the implementation
To ensure that the SPIFF (when present) is valid validate the properties of the header. This can be only be done after the frame info is also available.
This should fix the following compilation error on gcc-10:
In file included from charls/src/charls_jpegls_encoder.cpp:4:
charls/include/charls/charls_jpegls_encoder.h:520:119: error: attribute ‘access(read_only, 2, 3)’ positional argument 1 references non-pointer argument type ‘int32_t’ {aka ‘int’}
520 | CHARLS_IN_READS_BYTES(size) const void* application_data, const size_t size)
|
